Skip to content

[BUG] fix typing - typechecks error - #555

Merged
solegalli merged 9 commits into
feature-engine:mainfrom
glevv:typing-fix
Nov 9, 2022
Merged

[BUG] fix typing - typechecks error#555
solegalli merged 9 commits into
feature-engine:mainfrom
glevv:typing-fix

Conversation

@glevv

@glevv glevv commented Nov 8, 2022

Copy link
Copy Markdown
Contributor

Blocker

Needs to be checked and merged ASAP

@glevv
glevv marked this pull request as ready for review November 8, 2022 16:46
@codecov

codecov Bot commented Nov 8, 2022

Copy link
Copy Markdown

Codecov Report

Merging #555 (e4b7891) into main (5e0bf37) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #555   +/-   ##
=======================================
  Coverage   97.47%   97.47%           
=======================================
  Files          90       90           
  Lines        3480     3480           
  Branches      681      681           
=======================================
  Hits         3392     3392           
  Misses         32       32           
  Partials       56       56           
Impacted Files Coverage Δ
feature_engine/selection/drop_psi_features.py 98.30% <ø> (ø)
feature_engine/selection/shuffle_features.py 100.00% <ø> (ø)
...ure_engine/selection/single_feature_performance.py 100.00% <ø> (ø)
feature_engine/selection/target_mean_selection.py 97.05% <ø> (ø)
...imeseries/forecasting/expanding_window_features.py 89.18% <ø> (ø)
...ture_engine/timeseries/forecasting/lag_features.py 100.00% <ø> (ø)
...e_engine/timeseries/forecasting/window_features.py 100.00% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@solegalli solegalli changed the title [BUG] Typing fix [BUG] fix typing - typechecks error Nov 9, 2022
@solegalli
solegalli merged commit 22e6fbf into feature-engine:main Nov 9, 2022
@glevv
glevv deleted the typing-fix branch March 24, 2023 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants